Fall back to nearest quality instead of highest#2
Open
odium1963 wants to merge 1 commit intoFave42:masterfrom
Open
Fall back to nearest quality instead of highest#2odium1963 wants to merge 1 commit intoFave42:masterfrom
odium1963 wants to merge 1 commit intoFave42:masterfrom
Conversation
…lable Previously if the requested quality (e.g. 480p) was not in the source list, the downloader would silently jump to the highest available (1080p). Now it picks whichever quality is numerically closest to the requested one, so 480p falls back to 720p rather than 1080p. Co-Authored-By: odium1963 <odium71499@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Previously, requesting 480p on a source that only had 720p/1080p would silently download at 1080p. The new behaviour picks 720p instead, which better respects the user's intent.
Test plan
🤖 Generated with Claude Code